remove workspace #25046
Merged
remove workspace #25046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
force-pushed
the
fe/workspace
branch
from
3c6554c
to
4d99bc6
Compare
StefanKarpinski
approved these changes
Dec 12, 2017
NEWS.md
Outdated
| @@ -732,6 +732,8 @@ Deprecated or removed | |||
| * `trues(A::AbstractArray)` and `falses(A::AbstractArray)` are deprecated in favor of | |||
| `trues(size(A))` and `falses(size(A))` respectively ([#24595]). | |||
|
|
|||
| * `workspace` is discontinued ([#25046]). | |||
There was a problem hiding this comment.
Maybe a link to Revise?
fredrikekre
force-pushed
the
fe/workspace
branch
from
4d99bc6
to
f499b01
Compare
iblislin
reviewed
Dec 13, 2017
| @@ -732,6 +732,9 @@ Deprecated or removed | |||
| * `trues(A::AbstractArray)` and `falses(A::AbstractArray)` are deprecated in favor of | |||
| `trues(size(A))` and `falses(size(A))` respectively ([#24595]). | |||
|
|
|||
| * `workspace` is discontinued, check out [Revise.jl](https://github.com/timholy/Revise.jl) | |||
| for an alternative workflow ([#25046]). | |||
There was a problem hiding this comment.
😱 Revise.jl still doesn't work on FreeBSD
There was a problem hiding this comment.
issue filed.
timholy/Revise.jl#66
There was a problem hiding this comment.
@StefanKarpinski shouldn't this needed a deprecation warning too, not just deleting it?
Else people will just get an UndefVarError, with no idea that they should be checking out Revise.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #10351, close #22434