Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow use of begin blocks inside enum definitions #25424

Merged
merged 2 commits into from
Jan 6, 2018
Merged

Conversation

simonbyrne
Copy link
Contributor

No description provided.

base/Enums.jl Outdated
@enum EnumName begin
value1
value2
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to wrap this in triple backticks with a julia annotation so that it will be properly highlighted in the rendered docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I'll add a NEWS item too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ararslan ararslan added the needs news A NEWS entry is required for this change label Jan 5, 2018
@ararslan ararslan removed the needs news A NEWS entry is required for this change label Jan 6, 2018
Copy link
Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@ararslan ararslan merged commit dbf0b45 into master Jan 6, 2018
@ararslan ararslan deleted the sb/enumblock branch January 6, 2018 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants