Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a hook in base for disabling threading #30004

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Implement a hook in base for disabling threading #30004

merged 1 commit into from
Dec 7, 2018

Conversation

fredrikekre
Copy link
Member

Implement a hook in base for disabling threading of libraries, use it to decouple Distributed from LinearAlgebra.

Alternative to #29975, WIP because I don't know if this is the interface we want, where the code should live, and what the names of the functions should be. Maybe not very important since these are all internal functions.

@fredrikekre fredrikekre added the stdlib Julia's standard library label Nov 12, 2018
@fredrikekre
Copy link
Member Author

Ah, this is basically #25951 (comment)

@fredrikekre fredrikekre mentioned this pull request Nov 21, 2018
Closed
@fredrikekre
Copy link
Member Author

Bump for Julia 1.1

@KristofferC KristofferC added the triage This should be discussed on a triage call label Dec 4, 2018
vtjnash
vtjnash reviewed Dec 6, 2018
View reviewed changes
base/initdefs.jl Outdated Show resolved Hide resolved
@StefanKarpinski
Copy link
Member

Triage is in favor if you want to get this passing CI and merge it. Wants a NEWS entry too, right?

@StefanKarpinski StefanKarpinski removed the triage This should be discussed on a triage call label Dec 6, 2018
@StefanKarpinski StefanKarpinski added this to the 1.1 milestone Dec 6, 2018
@StefanKarpinski StefanKarpinski added the multithreading Base.Threads and related functionality label Dec 6, 2018
@fredrikekre
Implement a hook in base for disabling threading
7b48911 
of libraries, use it to decouple Distributed from LinearAlgebra.
@fredrikekre fredrikekre changed the title [WIP] Implement a hook in base for disabling threading Implement a hook in base for disabling threading Dec 6, 2018
@fredrikekre fredrikekre mentioned this pull request Dec 6, 2018
Closed
@fredrikekre
Copy link
Member Author

Great, updated. The last CI runs was during some flaky times IIRC, so I don't think there was something wrong with the PR.

@JeffBezanson JeffBezanson merged commit 5509306 into master Dec 7, 2018
@JeffBezanson JeffBezanson deleted the fe/threading_hook branch December 7, 2018 06:26
@ararslan
Copy link
Member

ararslan commented Dec 8, 2018

This seems to be causing the Distributed tests to fail on PkgEval:

ERROR: LoadError: On worker 2:
ArgumentError: Package LinearAlgebra not found in current path:
- Run `import Pkg; Pkg.add("LinearAlgebra")` to install the LinearAlgebra package.

@fredrikekre
Copy link
Member Author

#30311

@vchuravy vchuravy mentioned this pull request Oct 31, 2020
Closed
@vtjnash vtjnash mentioned this pull request Aug 9, 2022
Closed
Keno pushed a commit that referenced this pull request Jun 5, 2024
@fredrikekre @JeffBezanson
Implement a hook in base for disabling threading (#30004)
6eef924 
of libraries, use it to decouple Distributed from LinearAlgebra.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees
No one assigned
Labels
multithreading Base.Threads and related functionality stdlib Julia's standard library
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
6 participants
@fredrikekre @StefanKarpinski @ararslan @vtjnash @JeffBezanson @KristofferC