add InetAddr constructor from string #31459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
needs compat annotation
|
I've added a news entry. I think documentation should be added in a separate PR as here I'm just adding a constructor, the type existed already (unexported and undocumented). EDIT: nevermind, now I see the concern. If I don't add docs here it with compat annotation it'll be hard to tell in the future that one of the constructors was added afterwards. I've just added docs and compat annotation. |
fredrikekre
reviewed
Apr 3, 2019
|
Thanks for the feedback, I've included your suggestions! |
|
Changed version compat to 1.3, squashed and merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to write code that would work with either a
Stringor aIPAddr. Some packages like HTTP write their own internal method for this (https://github.com/JuliaWeb/HTTP.jl/blob/master/src/Servers.jl#L184) but I think something likeInetAddr("127.0.0.1", 8000)is sufficiently unambiguous that it should have its own official constructor.