-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize Emoji variant selectors in identifiers? #31588
Comments
A related issue: Should we change the |
I feel like emoji normalization is something we should leave to the Unicode consortium — it seems like they should really fix this in NFC, and it's not worth the effort for us to use a custom normalization here. For tab completion we can do whatever we want, of course. |
I agree. The main concern for identifier normalization is when two different identifiers are both easy to input and hard to distinguish. That doesn’t seem to be the case here. If the Unicode consortium decides to normalize these then we can follow suit. |
Isn't it? iTerm2 has decent unicode support, but half the other software I tried (including all editors we support) either render them the same or render one or the other as a replacement character. As for inputting them, if I google "telephone emoji" I get to https://emojipedia.org/black-telephone/ and if I copy that, I get the emoji variant, which is different from what you get by doing |
The most conservative option would be to reject modified emoji altogether. |
True, but for a number of emoji (☎️ being an example), the rendering that people identify with the emoji is the one that has the variant selector. |
These are hardly the confusable characters that I would worry about most (as opposed to, say, |
😂 too true |
Today I came across the existence of emoji variant selectors (basically what happened was that the unicode standard already had a bunch of symbols that were a little like emoji but not colorful, so they added a combining character to make those colorful and similarly to make emoji non-colorful). At the moment, we consider these significant in identifiers, so we allow things like:
We should make a decision on whether we want to normalize out this distinction in our identifier normalization.
The text was updated successfully, but these errors were encountered: