-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address part of #28866, prevent array operations from dropping 0d containers #32122
Conversation
Seems reasonable. I think whatever you end up deciding here is good, @mbauman. |
…tainers This is a simple workaround for the handful of elementwise operations that are defined on arrays _without_ the need for explicit broadcast but use broadcasting (with an extra shape check) in their implementation. These were the only affected cases I could find.
Failures were real and stemmed from the fact that LinearAlgebra specialized |
Look at all those green checks 😁 |
I say we do this. |
This is a simple workaround for the handful of elementwise operations that are defined on arrays without the need for explicit broadcast but use broadcasting (with an extra shape check) in their implementation. These were the only affected cases I could find.
This is restoring the intended behavior, and matches the behavior of Julia pre-0.7. It is a fairly impactful change, though, so even though I'd call it a bugfix we probably want to be conservative in our backporting.