Parenthesis in PATH causes build of libgfortran to fail in WSL

[BioTurboNick]

I don't know how much this matters per se, but having a parenthesis in the PATH variable (as sometimes occurs on Windows) seems to cause building of libgfortran to fail with

/bin/sh: 1: Syntax error: "(" unexpected

Changing line 267 of Makefile to place PATH in quotation marks appears to resolve the issue:
Current: -$(CUSTOM_LD_LIBRARY_PATH) PATH=$(PATH):$(build_depsbindir) $(JULIAHOME)/contrib/fixup-libgfortran.sh --verbose $(build_libdir)
Works(?): -$(CUSTOM_LD_LIBRARY_PATH) PATH="$(PATH):$(build_depsbindir)" $(JULIAHOME)/contrib/fixup-libgfortran.sh --verbose $(build_libdir)

This is in Windows Subsystem for Linux (Ubuntu) on Windows 10 x64. I'm not cross-compiling because that gave me other issues and I wanted to keep things simple.

[StefanKarpinski]

Is this a Julia issue? It doesn't seem to be.

[BioTurboNick]

Is there another place to register problems with the Makefile?

[StefanKarpinski]

I misunderstood, I thought it was just that /bin/sh on WSL didn't like some path names, in which case there would be little we could do about it. That line number has changed—I think it's now line 272—but it also looks like this is fixed on master:

julia/Makefile

Line 272 in 220681f

-$(CUSTOM_LD_LIBRARY_PATH) PATH="$(PATH):$(build_depsbindir)" $(JULIAHOME)/contrib/fixup-libgfortran.sh --verbose $(build_libdir)

Can you check if the latest release candidate has this problem?

[BioTurboNick]

Apologies, it was apparently fixed 5 months ago. I'm building from v1.2. Thanks!

[StefanKarpinski]

xref-ing issues: #32100