Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Quarter #35517

Closed
matthieugomez opened this issue Apr 18, 2020 · 4 comments
Closed

Feature request: Quarter #35517

matthieugomez opened this issue Apr 18, 2020 · 4 comments

Comments

@matthieugomez
Copy link
Contributor

Could there be a Quarter <: DatePeriod type in Dates?

@matthieugomez matthieugomez changed the title Feature request: Quarter type Feature request: Quarter Apr 18, 2020
@StefanKarpinski
Copy link
Member

Would that be different from 3 months in any way? My understanding of a quarter is that it's not a duration so much as a fixed splitting of each year. I.e. it's weird to say "a quarter later" if you mean "three months from today"; rather, you refer to the first, second, third and fourth quarters of a given year to refer to a period of time.

@matthieugomez
Copy link
Contributor Author

matthieugomez commented Apr 19, 2020

Public firms must report earnings every quarter — they do say "next quarter/last quarter".
Defining Quarter makes it easier to work with these accounting datasets (for instance, to compute the growth of earnings between this quarter and next quarter etc...).

Note that not all quarters start in January (Walmart's first quarter is February, March, and April; Apple Inc's Q1 is October, November, and December; Microsoft Corporation's Q1 is July, August, and September).

It is true that a quarter is exactly three months. But then a week is exactly seven days, and we still define Week <: TimePeriod.

@StefanKarpinski
Copy link
Member

👍 The PR looks non-trivial enough to make sense.

@matthieugomez
Copy link
Contributor Author

Solved by #36364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants