broaden/fix signature of nextprod #35791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ararslan
reviewed
May 7, 2020
Co-authored-by: Alex Arslan <ararslan@comcast.net>
eschnett
pushed a commit
to eschnett/julia
that referenced
this pull request
May 11, 2020
Roger-luo
pushed a commit
to Roger-luo/julia
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the first argument of
nextprodwas too narrow (Vector{Int}) whereas the second argument was too broad (::Any, whereas the definition requires::Realsimilar tonextpow).This PR broadens the signature of the first argument to tuples and abstractvectors of
<:Integer, while narrowing the second argument to::Realfor consistency withnextpowand integers factor. (The old method couldn't work for any non-Realtype anyway since the factors wereVector{Int}, so this shouldn't be breaking.)