Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RandomDevice in UUIDs instead of default_rng? #35860

Closed
tkf opened this issue May 12, 2020 · 2 comments · Fixed by #35872
Closed

Use RandomDevice in UUIDs instead of default_rng? #35860

tkf opened this issue May 12, 2020 · 2 comments · Fixed by #35872
Labels
good first issue Indicates a good issue for first-time contributors to Julia help wanted Indicates that a maintainer wants help on an issue or pull request

Comments

@tkf
Copy link
Member

tkf commented May 12, 2020

@c42f commented on #35833 (comment)

Actually this would suggest that the global RNG from Random isn't a great choice for UUIDs anyway because the user may control the seeding for reasons unrelated to UUIDs.

Maybe we should use Random.RandomDevice() instead of Random.default_rng() in UUIDs?

See also #32954 (comment)
@StefanKarpinski
Copy link
Member

Yes, I think that's a good idea.

@c42f
Copy link
Member

c42f commented May 13, 2020

Thanks so much @tkf for boldly making coherent issues out of my random side remarks 😅

@StefanKarpinski StefanKarpinski added good first issue Indicates a good issue for first-time contributors to Julia help wanted Indicates that a maintainer wants help on an issue or pull request labels May 13, 2020
@ssikdar1 ssikdar1 mentioned this issue May 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Indicates a good issue for first-time contributors to Julia help wanted Indicates that a maintainer wants help on an issue or pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change uuid to use Random.RandomDevice() instead of Random.default_rng() ssikdar1/julia
3 participants
@tkf @StefanKarpinski @c42f