Make view of a string return a substring #35879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
commented
May 13, 2020
oxinabox
commented
May 13, 2020
mbauman
reviewed
May 14, 2020
rfourquet
reviewed
May 16, 2020
oxinabox
force-pushed
the
ox/substringview
branch
from
7b89e86 to
b3e1837
Compare
stevengj
reviewed
May 17, 2020
|
This should be good to go now |
StefanKarpinski
approved these changes
May 19, 2020
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
* make taking views of string indexing give substrings * add news * Remove excess whitespace * handle single character string views correctly * test values of views * make substring etc work on AbstractUnitRanges * Fix missing space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the docs say
(emph, mine)
but without this PR
@view "abcd"[2:3]justMethodErrors