Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward incompatilbe change in detect_ambiguities #37360

Open
tkf opened this issue Sep 2, 2020 · 1 comment
Open

Backward incompatilbe change in detect_ambiguities #37360

tkf opened this issue Sep 2, 2020 · 1 comment
Labels
needs news A NEWS entry is required for this change testsystem The unit testing framework and Test stdlib

Comments

@tkf
Copy link
Member

tkf commented Sep 2, 2020

I just noticed that #36962 removed imported keyword argument from Test.detect_ambiguities. Since it is not mentioned in the documentation (https://docs.julialang.org/en/v1.6-dev/stdlib/Test/), it is technically unclear if we need to treat detect_ambiguities as public API. However, as it is exported since 2016 (Julia v0.5) be8679e, I suggest to treat this function as a public API.

@vtjnash Is it possible to add the new algorithm without changing the signature? At least, I think it's better to keep imported and show depwarn when non-default value is given.

I can create a PR to add no-op imported keyword argument if that's an appropriate solution.

@tkf tkf added the testsystem The unit testing framework and Test stdlib label Sep 2, 2020
@vtjnash
Copy link
Member

vtjnash commented Sep 2, 2020

Yeah, it’d just be ignored now. I was assuming most users would need to delete Base from the module list to pass the test anyways, so hadn’t worried about it.

@timholy timholy added the needs news A NEWS entry is required for this change label Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs news A NEWS entry is required for this change testsystem The unit testing framework and Test stdlib
Projects
None yet
Development

No branches or pull requests

3 participants