Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latency regression in optimizer #38045

Closed
JeffBezanson opened this issue Oct 15, 2020 · 3 comments
Closed

latency regression in optimizer #38045

JeffBezanson opened this issue Oct 15, 2020 · 3 comments
Labels
compiler:latency Compiler latency regression Regression in behavior compared to a previous version

Comments

@JeffBezanson
Copy link
Sponsor Member

Caused by #37884.
Before:

julia> @time using Plots
 84.830424 seconds (7.45 M allocations: 521.182 MiB, 0.16% gc time, 1.48% compilation time)

julia> @time display(plot(rand(10)))
  7.416645 seconds (11.68 M allocations: 676.491 MiB, 2.72% gc time, 95.68% compilation time)

After:

julia> @time using Plots
 85.947123 seconds (7.58 M allocations: 528.318 MiB, 0.16% gc time, 1.57% compilation time)

julia> @time display(plot(rand(10)))
  7.657525 seconds (11.81 M allocations: 688.000 MiB, 2.78% gc time, 95.82% compilation time)
@JeffBezanson JeffBezanson added regression Regression in behavior compared to a previous version compiler:latency Compiler latency labels Oct 15, 2020
@vchuravy
Copy link
Member

Happy to revert. I need it for follow up work, but I can reland it after the branch.

@oscardssmith
Copy link
Member

What's the status of this?

@vtjnash
Copy link
Sponsor Member

vtjnash commented Mar 31, 2021

I think we should just close. We need more significant changes to improve/fix this than this difference represents. But good to have this observation of timing. This is probably something we should track in BaseBenchmarks instead.

@vtjnash vtjnash closed this as completed Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:latency Compiler latency regression Regression in behavior compared to a previous version
Projects
None yet
Development

No branches or pull requests

4 participants