add replace methods for Tuple #38216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
added
the
collections
|
Bump |
JeffBezanson
reviewed
Dec 3, 2020
base/set.jl
Outdated
|
|
||
| ### replace for tuples | ||
|
|
||
| _replace(f::Callable, t::Tuple, count::Int) = |
There was a problem hiding this comment.
Should use the function keyword form.
|
From triage: we don't have a good way to implement this now, but the same holds for many tuple functions, so we might as well add this. |
JeffBezanson
approved these changes
Dec 3, 2020
rfourquet
force-pushed
the
rf/replace-tuple
branch
from
96935fc to
aa7ce21
Compare
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
* verbose replace for Tuple * add replace methods for Tuple
rfourquet
added a commit
that referenced
this pull request
Jul 25, 2021
The methods were added in #38216.
KristofferC
pushed a commit
that referenced
this pull request
Jul 28, 2021
The methods were added in #38216.
rfourquet
added a commit
that referenced
this pull request
Jul 31, 2021
The methods were added in #38216.
rfourquet
added a commit
that referenced
this pull request
Aug 13, 2021
The methods were added in #38216.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33782:
This must be squashed, but the first commit contains specialized implementations for small tuples, it seems useless so I deleted them, but wanted to keep it archived here, just in case :)
I spent one hour trying understand how performance works, with
@inlineor not, for different sizes of tuples, with or without keyword, with or without deferring tomapwhencount >= length(tuple)... I failed, so ended up without any@inline, this has decent performance.