Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the public Dates.periods function for getting the Vector of Periods that comprise a CompoundPeriod #39169

Merged
merged 3 commits into from
Jan 11, 2021

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Jan 10, 2021

Currently, there is no public API for getting the Vector of Periods that comprise a CompoundPeriod.

This pull request adds the public Dates.periods function for accomplishing this. (It has a docstring, and it is listed in the manual, therefore it is in the public API.)

@DilumAluthge DilumAluthge added the dates Dates, times, and the Dates stdlib module label Jan 10, 2021
@DilumAluthge DilumAluthge requested a review from kshyatt January 10, 2021 03:33
@DilumAluthge DilumAluthge changed the title Add the public Dates.periods function for getting the Vector of Periods that underly a CompoundPeriod Add the public Dates.periods function for getting the Vector of Periods that comprise a CompoundPeriod Jan 10, 2021
@DilumAluthge DilumAluthge added compiler:codegen Generation of LLVM IR and native code stdlib Julia's standard library and removed compiler:codegen Generation of LLVM IR and native code labels Jan 10, 2021
@DilumAluthge DilumAluthge requested a review from quinnj January 10, 2021 03:39
…Period`s that comprise a `CompoundPeriod`
@DilumAluthge DilumAluthge force-pushed the dpa/compoundperiod-periods branch from 0376e8c to 6535c23 Compare January 10, 2021 09:03
stdlib/Dates/src/periods.jl Outdated Show resolved Hide resolved
@quinnj quinnj merged commit 012349b into master Jan 11, 2021
@quinnj quinnj deleted the dpa/compoundperiod-periods branch January 11, 2021 04:15
@DilumAluthge
Copy link
Member Author

Thanks @quinnj!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dates Dates, times, and the Dates stdlib module stdlib Julia's standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants