Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add U+2AEA (⫪) and U+2AEB (⫫) to binary operators #39403

Merged
merged 4 commits into from
Apr 9, 2021
Merged

Add U+2AEA (⫪) and U+2AEB (⫫) to binary operators #39403

merged 4 commits into from
Apr 9, 2021

Conversation

jonas-schulze
Copy link
Contributor

Closes #39350

@jonas-schulze jonas-schulze added the unicode Related to unicode characters and encodings label Jan 26, 2021
@jonas-schulze
Copy link
Contributor Author

I don't know what to make of the failure. It looks unrelated but critical?

@jonas-schulze
Copy link
Contributor Author

@JeffBezanson bump 🙂

@simeonschaub simeonschaub added parser Language parsing and surface syntax needs news A NEWS entry is required for this change needs tests Unit tests are required for this change labels Feb 3, 2021
@simeonschaub
Copy link
Member

Thanks! Mostly looks good to me. I think it would be good to add a NEWS entry for this and a test in test/syntax.jl to make sure this actually works as expected.

@jonas-schulze jonas-schulze mentioned this pull request Feb 3, 2021
Merged
@jonas-schulze jonas-schulze removed needs news A NEWS entry is required for this change needs tests Unit tests are required for this change labels Feb 3, 2021
@jonas-schulze
Copy link
Contributor Author

Bump 🙂

@jonas-schulze jonas-schulze mentioned this pull request Feb 23, 2021
Closed
@musm
Copy link
Contributor

musm commented Apr 5, 2021

Looks like the NEWS file needs a quick rebase

@musm musm requested review from JeffBezanson and removed request for JeffBezanson April 7, 2021 17:19
@simeonschaub simeonschaub added the merge me PR is reviewed. Merge when all tests are passing label Apr 9, 2021
@simeonschaub simeonschaub merged commit 4996445 into JuliaLang:master Apr 9, 2021
@simeonschaub
Copy link
Member

Thanks, sorry for the long wait!

@simeonschaub simeonschaub removed the merge me PR is reviewed. Merge when all tests are passing label Apr 28, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@jonas-schulze @ElOceanografo
Add U+2AEA (⫪) and U+2AEB (⫫) to binary operators (JuliaLang#39403)
24936fe
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@jonas-schulze @antoine-levitt
Add U+2AEA (⫪) and U+2AEB (⫫) to binary operators (JuliaLang#39403)
df07c64
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@jonas-schulze @johanmon
Add U+2AEA (⫪) and U+2AEB (⫫) to binary operators (JuliaLang#39403)
df727e0
pfitzseb added a commit to JuliaLang/Tokenize.jl that referenced this pull request May 2, 2022
@pfitzseb
Add top/bot
848cad0 
JuliaLang/julia#39403
@pfitzseb pfitzseb mentioned this pull request May 2, 2022
Merged
@Moelf Moelf mentioned this pull request Jul 8, 2022
Closed
@t-bltg t-bltg mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonschaub simeonschaub simeonschaub approved these changes

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

Assignees
No one assigned
Labels
parser Language parsing and surface syntax unicode Related to unicode characters and encodings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow U+2AEB (⫫) as binary operator
3 participants
@jonas-schulze @simeonschaub @musm