@lock export from Base, closes #36441

[sairus7]

No description provided.

[ronisbr]

Hi @sairus7

Thanks for this PR! IMHO, to truly close #36441 we need to do the following in addition to export @lock:

1. Add a docstring to this macro.
2. Add a small text in the documentation showing in which contexts it should be used.

For more information, you can see: https://discourse.julialang.org/t/poor-performance-of-lock-l-do-closures-caused-by-poor-performance-of-capturing-closures/42067/13

EDIT: BTW, we also have the macro @lock_nofail for cases in which we can guarantee that the function will not throw any error. In this case, avoiding try catch can improve the performance. Hence, maybe we can also export this macro and add the documentation about it in this PR.

[vtjnash]

bump? needs docs and news for this

[sairus7]

@ronisbr I've added docstrings and @lock_nofail export.
Does it cover 1 and 2, or should I seach for some other places in documentation to add a mention about these macro? If so, can you point me to it?

[ronisbr]

Hi @sairus7 !

For me it is perfect and fully addressed my points 1 and 2. I think we only need to add an entry in NEWS.md informing that @lock and @lock_nofail is now exported.

[sairus7]

add an entry in NEWS.md informing that @lock and @lock_nofail is now exported

Seems NEWS.md file is excluded from julia repo, so how to do this?

[ronisbr]

Seems NEWS.md file is excluded from julia repo, so how to do this?

No, it does not seem to be excluded, check here:

https://github.com/JuliaLang/julia/blob/master/NEWS.md

[sairus7]

Added this to news, not sure if the right section.

[ronisbr]

LGTM!

[ronisbr]

@sairus7

We have a problem in the building:

base/lock.jl:208:`lock(l)` and `unlock(l)` functions. It is often more performant than function form 
base/lock.jl:227:Equivalent to `@lock l expr` for cases in which we can guarantee that the function 
Error: trailing whitespace found in source file(s)

I believe you need to remove trailing spaces from those doc strings.

[sairus7]

I think all conversations above are resolved now.

[NHDaly]

Fantastic, thanks all! :) 🙌

[ronisbr]

Nice!! Thank you @sairus7 for you contribution :)