Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackframe paths to Stdlib files incorrect #45294

Closed
BioTurboNick opened this issue May 12, 2022 · 3 comments
Closed

Stackframe paths to Stdlib files incorrect #45294

BioTurboNick opened this issue May 12, 2022 · 3 comments

Comments

@BioTurboNick
Copy link
Contributor

BioTurboNick commented May 12, 2022

Raising this comment on #33065 to a full issue because I just encountered it and realized it was leading to a weird bit of logic in my AbbreviatedStackTraces.jl package.

Base file paths all start with ./ or .\, but Stdlib paths all point to an absolute path that was present on the build machine. For consistency, if base is considered the working directory for stack traces, this could be ../stdlib/v1.8/.

In version 1.3.0 on Win_64 platform, I get this:

ERROR: MethodError: no method matching randstring(::Int64, ::String)
Closest candidates are:
  randstring(::AbstractRNG, ::Any) at D:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.3\Random\src\misc.jl:74

It must be a hard-coded path since this machine does not even contain a D drive.
The actual path is AppData\Local\

Originally posted by @K-Kent in #33065 (comment)

@BioTurboNick
Copy link
Contributor Author

I can try to address it myself, but would need input on the proper path to use instead.

@KristofferC
Copy link
Member

Call Base.fixup_stdlib_path on the path before showing it.

@BioTurboNick
Copy link
Contributor Author

Oh, thanks! I guess it was fixed in Base but I was overriding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants