Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findall(::Array{UInt8}, ::Array{UInt8}) not implemented #45295

Closed
getzze opened this issue May 12, 2022 · 1 comment · Fixed by #45307
Closed

findall(::Array{UInt8}, ::Array{UInt8}) not implemented #45295

getzze opened this issue May 12, 2022 · 1 comment · Fixed by #45307

Comments

@getzze
Copy link
Contributor

getzze commented May 12, 2022

Trying to use find* functions with UInt8 arrays, I found PR 37283.
In news.md, it says that "findfirst, findnext, findlast, and findall" support it, but it is wrong.
It is supported by findprev also and not by findall.

> VERSION
v"1.7.2"
> a = rand(UInt8, 2);
> b = rand(UInt8, 10);
> findfirst(a, b)

> findprev(a, b, 10)

> findall(a, b)
ERROR: MethodError: no method matching findall(::Vector{UInt8}, ::Vector{UInt8})
Closest candidates are:
  findall(::Base.Fix2{typeof(in), <:Union{Real, Array{<:Real}}}, ::Array{<:Real}) at /usr/share/julia/base/array.jl:2417
  findall(::Base.Fix2{typeof(in)}, ::AbstractArray) at /usr/share/julia/base/array.jl:2426
  findall(::Function, ::AbstractArray) at /usr/share/julia/base/array.jl:2257
  ...
@Moelf
Copy link
Contributor

Moelf commented May 13, 2022

I will take a look, thanks for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants