[REPL] broken tab completion layout for methods

[vtjnash]

julia> include(<tab>
include(mapexpr::Function, fname::AbstractString)
     @ Base.MainInclude client.jl:469                                                    include(fname::AbstractString)
     @ Base.MainInclude client.jl:470

expected (from v1.8):

julia> include(<tab>
include(mapexpr::Function, fname::AbstractString) in Base.MainInclude at client.jl:473  include(fname::AbstractString) in Base.MainInclude at client.jl:474

[Liozou]

This was introduced by #45069. On my ubuntu terminal it only appears when the terminal has a width greater than 177, if that can help to identify the bug. Otherwise (if the terminal is small enough), it appears as

julia> include(<tab>
include(mapexpr::Function, fname::AbstractString)
     @ Base.MainInclude client.jl:469
include(fname::AbstractString)
     @ Base.MainInclude client.jl:470

which I assume is the new intended behaviour.

[Seelengrab]

I was not aware of tab completion falling back to method printing directly - I'd have assumed it had more custom printing, since this should have been a problem with longer function signatures already, right?

Printing them in one column seems like a good alternative!

[Liozou]

That's frankly understandable since there was no test on the printing of multicolumn REPL completion. The fix for this issue at #45844 (awaiting review) includes one.

It was not actually a problem with long function signatures because multi-column printing is decided depending on the width of the largest completion, so if one was too large it reverts to being on a single column. The only implicit assumption that #45069 broke was that no completion would include a newline, but that should have been tested.