Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document memory model of Per-field atomics #46739

Open
Seelengrab opened this issue Sep 13, 2022 · 5 comments
Open

Document memory model of Per-field atomics #46739

Seelengrab opened this issue Sep 13, 2022 · 5 comments
Assignees
Labels
atomics docs This change adds or pertains to documentation forget me not PRs that one wants to make sure aren't forgotten

Comments

@Seelengrab
Copy link
Contributor

Seelengrab commented Sep 13, 2022

As the docs say, this will be published "later":

Specific details of the memory model and other details of the design are written in the Julia Atomics Manifesto, which will later be published formally.

Per-field atomics

Additionally, the linked manifesto has a number of TODOs that may or may not have been decided by now (I hope they are - some of them seem to be concerned with how this will be/is implemented..). 1.7 will have been released for 1 year in just about 3 months as of opening of this issue, so getting that done would probably be good.

@IanButterworth IanButterworth added the docs This change adds or pertains to documentation label Sep 13, 2022
@IanButterworth IanButterworth added this to the 1.9 milestone Sep 13, 2022
@KristofferC KristofferC removed this from the 1.9 milestone Dec 14, 2022
@KristofferC
Copy link
Sponsor Member

I don't think this is release blocking.

@Seelengrab
Copy link
Contributor Author

Seelengrab commented Dec 14, 2022

I think this got tagged with 1.9 as a kind of "forget me not", precisely because this is a core language feature that users should be able to rely on, with documentation supporting it. I fear that this issue will, like so many others tagged with doc, linger on and on - except it's worse in this case, since it's a core language feature and not some not-so-clear docstring of a minor function. Without that documentation, how are users supposed to rely on the semantics introduced by that feature?

@KristofferC KristofferC added the forget me not PRs that one wants to make sure aren't forgotten label Dec 14, 2022
@StefanKarpinski
Copy link
Sponsor Member

StefanKarpinski commented Dec 15, 2022

Who is the right person to document this? Presumably @vtjnash (who I've already assigned).

@Seelengrab
Copy link
Contributor Author

Seelengrab commented Dec 16, 2022

Probably, yeah, since he's the original author of the manifesto & main implementer of this? I'd offer to write it up, but I have no clue how this is implemented, what considerations were used in the implementation, what changed from manifesto to implementation etc.. Though educational, reverse engineering would probably take considerably longer and some important part would probably be missed 🤷

@Seelengrab
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atomics docs This change adds or pertains to documentation forget me not PRs that one wants to make sure aren't forgotten
Projects
None yet
Development

No branches or pull requests

6 participants