Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort(x::Matrix; dims) bypasses fpsort! #47721

Closed
LilithHafner opened this issue Nov 28, 2022 · 0 comments · Fixed by #47383
Closed

sort(x::Matrix; dims) bypasses fpsort! #47721

LilithHafner opened this issue Nov 28, 2022 · 0 comments · Fixed by #47383
Labels
performance Must go faster sorting Put things in order

Comments

@LilithHafner
Copy link
Member

This is because sort(::Matrix; dims) calls the 6-argument sort!(::AbstractVector, lo::Integer, hi::Integer, ::Algorithm, ::Ordering, temp) and the lack of lo and hi arguments is what triggers dispatch to fpsort!. This also precludes the use of radix sort on sort(::Matrix; dims).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Must go faster sorting Put things in order
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant