-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sort! >1D array along dimension #5284
Comments
The documentation for What's the status on this? Will we support inplace sorting of other dimensions? |
Once we have ArrayViews, this can be done through a view, no? |
Yeah, I think that's the right way forward. Let's wait till ArrayViews happen and then this can be sorted out. |
@jiahao, get off of Jacob's account. |
Wait, what? |
I think Stefan was complementing @quinnj's punny response. |
I feel mildly out of sorts. |
I hope so, that was the main intent of this report. The documentation was just a side-issue. |
Since f4b378b, it is no more possible to sort an
AbstractArray
in-place along a specific dimension.Before that commit, the necessary function for this was created by the
in_place_matrix_op
macro (L445). Earlier still (de7fb8b), it was implemented by callingsort!
onsub
s of the array (R239). I hope that it's been omitted by accident and not by intent, since it's a very useful feature to have!In any case, the documentation of
sort!
should be updated, since its signature still contains the[dim, ]
argument but the description doesn't talk about it at all.I'm afraid my julia-foo isn't strong enough yet to write a pull-request for this or even to decide whether just putting the implementation calling the
sub
s back in is good enough.The text was updated successfully, but these errors were encountered: