Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort! >1D array along dimension #5284

Closed
lucasb-eyer opened this issue Jan 2, 2014 · 8 comments · Fixed by #28902
Closed

sort! >1D array along dimension #5284

lucasb-eyer opened this issue Jan 2, 2014 · 8 comments · Fixed by #28902
Assignees
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request

Comments

@lucasb-eyer
Copy link
Contributor

Since f4b378b, it is no more possible to sort an AbstractArray in-place along a specific dimension.

Before that commit, the necessary function for this was created by the in_place_matrix_op macro (L445). Earlier still (de7fb8b), it was implemented by calling sort! on subs of the array (R239). I hope that it's been omitted by accident and not by intent, since it's a very useful feature to have!

In any case, the documentation of sort! should be updated, since its signature still contains the [dim, ] argument but the description doesn't talk about it at all.

I'm afraid my julia-foo isn't strong enough yet to write a pull-request for this or even to decide whether just putting the implementation calling the subs back in is good enough.

@quinnj
Copy link
Member

quinnj commented Aug 8, 2014

The documentation for sort! has been updated.

What's the status on this? Will we support inplace sorting of other dimensions?

@StefanKarpinski
Copy link
Member

Once we have ArrayViews, this can be done through a view, no?

@quinnj
Copy link
Member

quinnj commented Aug 8, 2014

Yeah, I think that's the right way forward. Let's wait till ArrayViews happen and then this can be sorted out.

@StefanKarpinski
Copy link
Member

@jiahao, get off of Jacob's account.

@quinnj
Copy link
Member

quinnj commented Aug 8, 2014

Wait, what?

@kmsquire
Copy link
Member

kmsquire commented Aug 8, 2014

I think Stefan was complementing @quinnj's punny response.

@jiahao
Copy link
Member

jiahao commented Aug 8, 2014

I feel mildly out of sorts.

@lucasb-eyer
Copy link
Contributor Author

Will we support inplace sorting of other dimensions?

I hope so, that was the main intent of this report. The documentation was just a side-issue.

@kmsquire kmsquire self-assigned this Jun 26, 2015
@JeffBezanson JeffBezanson added the help wanted Indicates that a maintainer wants help on an issue or pull request label Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants