Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion error in type intersection when testing NDTensors on 1.11 #53621

Closed
KristofferC opened this issue Mar 6, 2024 · 2 comments · Fixed by #53553
Closed

Assertion error in type intersection when testing NDTensors on 1.11 #53621

KristofferC opened this issue Mar 6, 2024 · 2 comments · Fixed by #53553
Labels
bisect wanted MWE wanted regression Regression in behavior compared to a previous version types and dispatch Types, subtyping and method dispatch
Milestone

Comments

@KristofferC
Copy link
Member

Put this in the REPL:

using NDTensors
dev = NDTensors.Unwrap.cpu
elt = Float32
S = dev(tensor(Diag(randn(elt, 2)), (2, 2)))
V = dev(tensor(Dense(randn(elt, 12, 2)'), (3, 4, 2)))
S1 = contract(S, (2, -1), V, (3, 4, -1))
julia> S1 = contract(S, (2, -1), V, (3, 4, -1))
Assertion failed: (!has_innerdep || btemp->depth0 == vb->depth0), function finish_unionall, file subtype.c, line 2916.

[98613] signal 6: Abort trap: 6
in expression starting at REPL[6]:1
__pthread_kill at /usr/lib/system/libsystem_kernel.dylib (unknown line)
pthread_kill at /usr/lib/system/libsystem_pthread.dylib (unknown line)
abort at /usr/lib/system/libsystem_c.dylib (unknown line)
__assert_rtn at /usr/lib/system/libsystem_c.dylib (unknown line)
finish_unionall at /Users/kristoffercarlsson/julia1.11/src/subtype.c:2916
intersect_unionall_ at /Users/kristoffercarlsson/julia1.11/src/subtype.c:3125
intersect_unionall at /Users/kristoffercarlsson/julia1.11/src/subtype.c:3173
intersect at /Users/kristoffercarlsson/julia1.11/src/subtype.c:3822
intersect_unionall_ at /Users/kristoffercarlsson/julia1.11/src/subtype.c:3082
intersect_unionall at /Users/kristoffercarlsson/julia1.11/src/subtype.c:3173
intersect at /Users/kristoffercarlsson/julia1.11/src/subtype.c:3822
intersect_all at /Users/kristoffercarlsson/julia1.11/src/subtype.c:4042
intersect_aside at /Users/kristoffercarlsson/julia1.11/src/subtype.c:2395
intersect at /Users/kristoffercarlsson/julia1.11/src/subtype.c:3766
intersect_all at /Users/kristoffercarlsson/julia1.11/src/subtype.c:4042
intersect_aside at /Users/kristoffercarlsson/julia1.11/src/subtype.c:2395
var_lt at /Users/kristoffercarlsson/julia1.11/src/subtype.c:728
local_forall_exists_subtype at /Users/kristoffercarlsson/julia1.11/src/subtype.c:1572
forall_exists_equal at /Users/kristoffercarlsson/julia1.11/src/subtype.c:1615
subtype at /Users/kristoffercarlsson/julia1.11/src/subtype.c:1445
subtype_unionall at /Users/kristoffercarlsson/julia1.11/src/subtype.c:907
subtype_unionall at /Users/kristoffercarlsson/julia1.11/src/subtype.c:907
...
@KristofferC KristofferC added regression Regression in behavior compared to a previous version types and dispatch Types, subtyping and method dispatch bisect wanted MWE wanted labels Mar 6, 2024
@KristofferC KristofferC added this to the 1.11 milestone Mar 6, 2024
@KristofferC
Copy link
Member Author

cc @N5N3 since you added that assert

@N5N3
Copy link
Member

N5N3 commented Mar 6, 2024

Confirmed that a556af2 fixes the example above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bisect wanted MWE wanted regression Regression in behavior compared to a previous version types and dispatch Types, subtyping and method dispatch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants