Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPL: path completion hints shouldn't expand ~ to user dir #53884

Closed
IanButterworth opened this issue Mar 28, 2024 · 1 comment · Fixed by #54311
Closed

REPL: path completion hints shouldn't expand ~ to user dir #53884

IanButterworth opened this issue Mar 28, 2024 · 1 comment · Fixed by #54311
Labels
REPL Julia's REPL (Read Eval Print Loop)

Comments

@IanButterworth
Copy link
Member

This behavior makes sense for the tab complete, but hints probably shouldn't prematurely expand ~

Screenshot 2024-03-28 at 10 44 34 AM

Screenshot 2024-03-28 at 10 41 00 AM
@IanButterworth IanButterworth added the REPL Julia's REPL (Read Eval Print Loop) label Mar 28, 2024
@IanButterworth
Copy link
Member Author

IanButterworth commented Apr 6, 2024 •
edited
Loading

I've got this fixed for strings, but the shell prompt uses another dissimilar code path and that's not working yet.
There seems to be quite a lot of code duplication in REPLCompletions which makes it harder to fix.

master...IanButterworth:julia:ib/hint_expanduser

@IanButterworth IanButterworth mentioned this issue Apr 30, 2024
Merged
IanButterworth added a commit that referenced this issue May 6, 2024
@IanButterworth
REPL: fix hinting without expanding user (#54311)
1221160 
Fixes #53884

Hints will show without expanding `~`, then a tab will complete the
shown hint, then a second tab on the resulting valid path expands `~`. I
think it makes sense?



https://github.com/JuliaLang/julia/assets/1694067/05a4fa97-2a85-4f90-8591-162256cf0704
KristofferC pushed a commit that referenced this issue May 20, 2024
@IanButterworth
REPL: fix hinting without expanding user (#54311)
e50c7e9 
Fixes #53884

Hints will show without expanding `~`, then a tab will complete the
shown hint, then a second tab on the resulting valid path expands `~`. I
think it makes sense?

https://github.com/JuliaLang/julia/assets/1694067/05a4fa97-2a85-4f90-8591-162256cf0704
(cherry picked from commit 1221160)
KristofferC pushed a commit that referenced this issue May 23, 2024
@IanButterworth
REPL: fix hinting without expanding user (#54311)
d4e097b 
Fixes #53884

Hints will show without expanding `~`, then a tab will complete the
shown hint, then a second tab on the resulting valid path expands `~`. I
think it makes sense?

https://github.com/JuliaLang/julia/assets/1694067/05a4fa97-2a85-4f90-8591-162256cf0704
(cherry picked from commit 1221160)
lazarusA pushed a commit to lazarusA/julia that referenced this issue Jul 12, 2024
@IanButterworth @lazarusA
REPL: fix hinting without expanding user (JuliaLang#54311)
d6085b1 
Fixes JuliaLang#53884

Hints will show without expanding `~`, then a tab will complete the
shown hint, then a second tab on the resulting valid path expands `~`. I
think it makes sense?



https://github.com/JuliaLang/julia/assets/1694067/05a4fa97-2a85-4f90-8591-162256cf0704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REPL: fix hinting without expanding user IanButterworth/julia
1 participant
@IanButterworth