Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: short change list? #8884

Closed
wavexx opened this issue Nov 3, 2014 · 5 comments
Closed

Documentation: short change list? #8884

wavexx opened this issue Nov 3, 2014 · 5 comments
Labels
docs This change adds or pertains to documentation

Comments

@wavexx
Copy link
Contributor

wavexx commented Nov 3, 2014

matplotlib has a nice convention of keeping track of user-visible changes, by requiring to append a very short summary to a whats_new/[file] directory. These files are cat-ed together for a final developer-friently changelog.

I really like the idea a lot. Since I'm following the master branch, there are just too many changes to follow by looking at the commit log. I'd like to have just a summary of user visible changes, such as new interfaces, new APIs, etc.

To give an example, see PR #7616. It would be nice to have just a line saying "host count is now supported in the machine file". If I'm interested, I could just blame the changelog and see the relevant commit for full details.

Nothing fancy; just something that takes seconds and adds convenience for developers.

The mpl approach to generate a nice-looking whats_new is also a bit overkill at this stage. Just a bullet list in a text file would be good.

@timholy
Copy link
Member

timholy commented Nov 3, 2014

You mean, something like NEWS.md?

@ivarne ivarne added the docs This change adds or pertains to documentation label Nov 3, 2014
@wavexx
Copy link
Contributor Author

wavexx commented Nov 3, 2014

Ha, yes ;).

Then maybe I should have updated NEWS.md for that particular PR?

@timholy
Copy link
Member

timholy commented Nov 3, 2014

Sure, that would be great.

@wavexx
Copy link
Contributor Author

wavexx commented Nov 3, 2014

Ok then, sorry for the noise. I'll file a separate PR.
Maybe maintainers should promote NEWS more actively when relevant?
I know mpl guys enforce this when the changes are relevant.

@ivarne
Copy link
Member

ivarne commented Nov 3, 2014

A new PR with NEWS.md notes for #7616 would be great indeed.

We definitely should be more careful to promote lots of things. We have come a long way though, because previously we have accepted PRs with new functions that were both undocumented and without tests. That won't happen anymore.

I'm closing this now, because (I think) we have clarified everything needed here.

@ivarne ivarne closed this as completed Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

No branches or pull requests

3 participants