From e39093619d0dd532c32ba52f70cdf21d9920b6b1 Mon Sep 17 00:00:00 2001 From: Brandon Edwards Date: Fri, 26 Aug 2016 19:36:22 -0400 Subject: [PATCH 1/5] Fix #18189 (Add deprecation of etc. to NEWS) --- NEWS.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/NEWS.md b/NEWS.md index 530777425f5b8..a4bce3f6fdc83 100644 --- a/NEWS.md +++ b/NEWS.md @@ -478,6 +478,16 @@ Deprecated or removed * The no-op `transpose` fallback has been deprecated. Consider introducing suitable `transpose` methods or calling `permutedims(x, [2,1])` ([#13171], [#17075], [#17374]). + * The following macros have been deprecated ([#18189]): + * `@windows` is deprecated in favor of `@static is_windows()` + * `@unix` is deprecated in favor of `@static is_unix()` + * `@osx` is deprecated in favor of `@static is_apple()` + * `@linux` is deprecated in favor of `@static is_linux()` + * `@windows_only` is deprecated in favor of `@static if is_windows()` + * `@unix_only` is deprecated in favor of `@static if is_unix()` + * `@osx_only` is deprecated in favor of `@static if is_apple()` + * `@linux_only` is deprecated in favor of `@static if is_linux()` + Command-line option changes --------------------------- From f8e7a43f0e3198f4aa57c15f414da8d0bb7a4109 Mon Sep 17 00:00:00 2001 From: Brandon Edwards Date: Fri, 26 Aug 2016 20:25:47 -0400 Subject: [PATCH 2/5] Remove mentioning of @static, add as a note --- NEWS.md | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/NEWS.md b/NEWS.md index a4bce3f6fdc83..b0adfb6722966 100644 --- a/NEWS.md +++ b/NEWS.md @@ -479,14 +479,15 @@ Deprecated or removed `transpose` methods or calling `permutedims(x, [2,1])` ([#13171], [#17075], [#17374]). * The following macros have been deprecated ([#18189]): - * `@windows` is deprecated in favor of `@static is_windows()` - * `@unix` is deprecated in favor of `@static is_unix()` - * `@osx` is deprecated in favor of `@static is_apple()` - * `@linux` is deprecated in favor of `@static is_linux()` - * `@windows_only` is deprecated in favor of `@static if is_windows()` - * `@unix_only` is deprecated in favor of `@static if is_unix()` - * `@osx_only` is deprecated in favor of `@static if is_apple()` - * `@linux_only` is deprecated in favor of `@static if is_linux()` + * `@windows` is deprecated in favor of `is_windows()` + * `@unix` is deprecated in favor of `is_unix()` + * `@osx` is deprecated in favor of `is_apple()` + * `@linux` is deprecated in favor of `is_linux()` + * `@windows_only` is deprecated in favor of `if is_windows()` + * `@unix_only` is deprecated in favor of `if is_unix()` + * `@osx_only` is deprecated in favor of `if is_apple()` + * `@linux_only` is deprecated in favor of `if is_linux()` + * NOTE: Using `@static` could be useful/necessary when used in a function's local scope. Command-line option changes --------------------------- From 138194676536bffb862b31f7601f8e3e7c30e886 Mon Sep 17 00:00:00 2001 From: Brandon Edwards Date: Mon, 29 Aug 2016 23:01:24 -0400 Subject: [PATCH 3/5] Added reference to Handling Operating System Variation section in manual --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index b0adfb6722966..4cc36c8da34c9 100644 --- a/NEWS.md +++ b/NEWS.md @@ -487,7 +487,7 @@ Deprecated or removed * `@unix_only` is deprecated in favor of `if is_unix()` * `@osx_only` is deprecated in favor of `if is_apple()` * `@linux_only` is deprecated in favor of `if is_linux()` - * NOTE: Using `@static` could be useful/necessary when used in a function's local scope. + * NOTE: Using `@static` could be useful/necessary when used in a function's local scope. See details at the section entitled [Handling Operating System Variation](http://docs.julialang.org/en/latest/manual/handling-operating-system-variation/#man-handling-operating-system-variation) in the manual. Command-line option changes --------------------------- From fabb96e3acd67689d0937aa24edbf77a201cb546 Mon Sep 17 00:00:00 2001 From: Brandon Edwards Date: Mon, 29 Aug 2016 23:05:03 -0400 Subject: [PATCH 4/5] Changed reference numbers --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index 4cc36c8da34c9..673c2738f4764 100644 --- a/NEWS.md +++ b/NEWS.md @@ -478,7 +478,7 @@ Deprecated or removed * The no-op `transpose` fallback has been deprecated. Consider introducing suitable `transpose` methods or calling `permutedims(x, [2,1])` ([#13171], [#17075], [#17374]). - * The following macros have been deprecated ([#18189]): + * The following macros have been deprecated ([#6674] and [#4233]): * `@windows` is deprecated in favor of `is_windows()` * `@unix` is deprecated in favor of `is_unix()` * `@osx` is deprecated in favor of `is_apple()` From f9c3f5ce837d1878ec3f560dce80262d214d2470 Mon Sep 17 00:00:00 2001 From: Brandon Edwards Date: Thu, 1 Sep 2016 23:05:28 -0400 Subject: [PATCH 5/5] Change PR number --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index 673c2738f4764..0cd0ee6f1f31e 100644 --- a/NEWS.md +++ b/NEWS.md @@ -478,7 +478,7 @@ Deprecated or removed * The no-op `transpose` fallback has been deprecated. Consider introducing suitable `transpose` methods or calling `permutedims(x, [2,1])` ([#13171], [#17075], [#17374]). - * The following macros have been deprecated ([#6674] and [#4233]): + * The following macros have been deprecated ([#16219]): * `@windows` is deprecated in favor of `is_windows()` * `@unix` is deprecated in favor of `is_unix()` * `@osx` is deprecated in favor of `is_apple()`