From 0836ea040dbe48c415a4687fb4356815628ecf3f Mon Sep 17 00:00:00 2001
From: kshyatt <kshyatt@physics.ucsb.edu>
Date: Thu, 19 Jan 2017 17:31:51 -0700
Subject: [PATCH] At least WARN if revparse{id} fails

---
 base/libgit2/repository.jl | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/base/libgit2/repository.jl b/base/libgit2/repository.jl
index 0da122bca9569..0e439bec6a7b6 100644
--- a/base/libgit2/repository.jl
+++ b/base/libgit2/repository.jl
@@ -76,16 +76,25 @@ end
 """ Returns a found object """
 function revparse(repo::GitRepo, objname::AbstractString)
     obj_ptr_ptr = Ref{Ptr{Void}}(C_NULL)
-    err = ccall((:git_revparse_single, :libgit2), Cint,
-            (Ptr{Ptr{Void}}, Ptr{Void}, Cstring), obj_ptr_ptr, repo.ptr, objname)
-    err != 0 && return nothing
+    @check ccall((:git_revparse_single, :libgit2), Cint,
+           (Ptr{Ptr{Void}}, Ptr{Void}, Cstring), obj_ptr_ptr, repo.ptr, objname)
     return GitUnknownObject(repo, obj_ptr_ptr[])
 end
 
 """ Returns id of a found object """
 function revparseid(repo::GitRepo, objname::AbstractString)
-    obj = revparse(repo, objname)
-    obj === nothing && return GitHash()
+    local obj
+    try
+        obj = revparse(repo, objname)
+    catch err
+        if isa(err, GitError)
+            warn("Problem in revparse for $objname:")
+            show(err)
+            return GitHash()
+        else
+            rethrow(err)
+        end
+    end
     oid = GitHash(obj.ptr)
     close(obj)
     return oid