Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix improper FFTW function deprecation #22391

Merged
merged 2 commits into from
Jun 16, 2017
Merged

Fix improper FFTW function deprecation #22391

merged 2 commits into from
Jun 16, 2017

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented Jun 16, 2017

I changed something incorrectly during a rebase in #21956. This now works as expected:

julia> fft(1)
ERROR: fft has been moved to the package FFTW.jl.
Run `Pkg.add("FFTW")` to install FFTW then run `using FFTW` to load it.
Stacktrace:
 [1] #fft#8(::Array{Any,1}, ::Function, ::Int64, ::Vararg{Int64,N} where N) at ./deprecated.jl:1457
 [2] fft(::Int64, ::Vararg{Int64,N} where N) at ./deprecated.jl:1457

@JeffBezanson
Copy link
Member

The official way to handle this is you need to double-interpolate: "$($x)":

julia> x = 88
88

julia> :($x, "$x", "$($x)")
:((88, "$(x)", "$(88)"))

@ararslan
Copy link
Member Author

Yep, just realized that and changed it here. Thanks!

@ararslan ararslan added bugfix This change fixes an existing bug deprecation This change introduces or involves a deprecation labels Jun 16, 2017
@ararslan ararslan merged commit d49469d into master Jun 16, 2017
@ararslan ararslan deleted the aa/fix-fftw branch June 16, 2017 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug deprecation This change introduces or involves a deprecation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants