Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eliminate full from test/linalg/[dense|diagonal.jl] #23890

Merged
merged 1 commit into from
Sep 27, 2017
Merged

eliminate full from test/linalg/[dense|diagonal.jl] #23890

merged 1 commit into from
Sep 27, 2017

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Sep 27, 2017

Another small step towards deprecation of full. Ref. JuliaLang/LinearAlgebra.jl#229, JuliaLang/LinearAlgebra.jl#231, #18850, and linked threads. Best!

@Sacha0 Sacha0 added the linear algebra Linear algebra label Sep 27, 2017
@Sacha0 Sacha0 added this to the 1.0 milestone Sep 27, 2017
fredrikekre
fredrikekre approved these changes Sep 27, 2017
View reviewed changes
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason you choose Matrix over Array in this PR compared to the other ones? FWIW I like Matrix better :)

@andreasnoack andreasnoack merged commit 8c07a51 into JuliaLang:master Sep 27, 2017
@Sacha0
Copy link
Member Author

Sacha0 commented Sep 27, 2017

Any particular reason you choose Matrix over Array in this PR compared to the other ones? FWIW I like Matrix better :)

I likewise prefer the tighter Matrix :). (No good reason for Array in the preceding / other pull requests: I wrote Array by force of habit in the first few, and switched to Matrix when I thought of it.)

Thanks all! :)

@Sacha0 Sacha0 deleted the rftestdd branch September 27, 2017 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@Sacha0 @fredrikekre @andreasnoack