Doc some string parsing macros #28067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
docs
StefanKarpinski
approved these changes
Jul 11, 2018
|
#27949 also cover this topic |
|
@strickek thank you for pointing that PR out. Since those tests pass and it's more comprehensive, let's focus on getting that in a state to merge! |
|
FWIW, I think this PR is more complete for the macros that it covers and the other PR is a bit iffy for the other two macros (I had review comments on both), so I'd rather merge this now and then the other one can resolve the conflicts and include the best of both when it's ready. |
|
Ah ok, reopen it then if you like
…On Thu, Jul 12, 2018, 11:17 AM Stefan Karpinski ***@***.***> wrote:
FWIW, I think this PR is more complete for the macros that it covers and
the other PR is a bit iffy for the other two macros (I had review comments
on both), so I'd rather merge this now and then the other one can resolve
the conflicts and include the best of both when it's ready.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#28067 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAyk4xf1w6_MrG95p5rnArdjXZHWvSB3ks5uF2iWgaJpZM4VL2zj>
.
|
|
Can't, there's a different PR on the same branch! |
|
This PR should use the string macro syntax though |
|
@KristofferC I can show both? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.