-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docstrings for quot, isexpr and show_sexpr #31246
Conversation
The metaprogramming manual section on |
Yeah, I read that section, but I still don't get it. Also I am not very familiar with scheme. |
Ok I think I get the difference now: julia> quot(Expr(:$, :(1+2))) |> eval
3
julia> QuoteNode(Expr(:$, :(1+2))) |> eval
:($(Expr(:$, :(1 + 2)))) |
Correct. |
I think this is ready. |
bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please add the # Examples
headers before doctests in the docstrings.
Co-Authored-By: jw3126 <jw3126@gmail.com>
Co-Authored-By: jw3126 <jw3126@gmail.com>
Co-Authored-By: jw3126 <jw3126@gmail.com>
Co-Authored-By: jw3126 <jw3126@gmail.com>
Co-Authored-By: jw3126 <jw3126@gmail.com>
Merge? |
Towards #26919
I would also like to add a docstring for QuoteNode. But despite reading this it is not clear to me:
Expr(:quote,...)
andQuoteNode
is