From 4d215e4b55238c9cd5815b9bdac493a723560d14 Mon Sep 17 00:00:00 2001 From: Sebastian Stock <42280794+sostock@users.noreply.github.com> Date: Thu, 30 Jul 2020 10:23:04 +0200 Subject: [PATCH] Fix allunique(::StepRangeLen) --- base/set.jl | 4 +--- test/sets.jl | 7 +++++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/base/set.jl b/base/set.jl index afc118edb2526..e8591a1f748e2 100644 --- a/base/set.jl +++ b/base/set.jl @@ -393,9 +393,7 @@ end allunique(::Union{AbstractSet,AbstractDict}) = true -allunique(r::AbstractRange{T}) where {T} = (step(r) != zero(T)) || (length(r) <= 1) -allunique(r::StepRange{T,S}) where {T,S} = (step(r) != zero(S)) || (length(r) <= 1) -allunique(r::StepRangeLen{T,R,S}) where {T,R,S} = (step(r) != zero(S)) || (length(r) <= 1) +allunique(r::AbstractRange) = !iszero(step(r)) || length(r) <= 1 filter!(f, s::Set) = unsafe_filter!(f, s) diff --git a/test/sets.jl b/test/sets.jl index 3c213b5426c9d..45d1044720843 100644 --- a/test/sets.jl +++ b/test/sets.jl @@ -458,6 +458,13 @@ end @test allunique(Date(2018, 8, 7):Day(1):Date(2018, 8, 11)) # JuliaCon 2018 @test allunique(DateTime(2018, 8, 7):Hour(1):DateTime(2018, 8, 11)) @test allunique(('a':1:'c')[1:2]) == true + for r = (Base.OneTo(-1), Base.OneTo(0), Base.OneTo(1), Base.OneTo(5), + 1:0, 1:1, 1:2, 1:10, 1:.5:.5, 1:.5:1, 1:.5:10, 3:-2:5, 3:-2:3, 3:-2:1, + StepRangeLen(1.0, 2.0, 0), StepRangeLen(1.0, 2.0, 2), StepRangeLen(1.0, 2.0, 3), + StepRangeLen(1.0, 0.0, 0), StepRangeLen(1.0, -0.0, 1), StepRangeLen(1.0, 0.0, 2), + LinRange(1, 2, 3), LinRange(1, 1, 0), LinRange(1, 1, 1), LinRange(1, 1, 10)) + @test allunique(r) == invoke(allunique, Tuple{Any}, r) + end end @testset "filter(f, ::$S)" for S = (Set, BitSet) s = S([1,2,3,4])