Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] add sysimage size to make output report #47256

Closed

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Oct 20, 2022

This seems the wrong way to report size because the file isn't finished being written to Now calculates the size later

Generating REPL precompile statements... 40/40
Executing precompile statements... 1828/1871
Precompilation complete. Summary:
Generation ── 106.718929 seconds 75.3884%
Execution ───  34.839853 seconds 24.6116%
Total ─────── 141.558782 seconds
Outputting sysimage file...
Output ────── 146.560538 seconds, sysimage size: 153.216 MiB
    LINK usr/lib/julia/sys.dylib

@vchuravy
Copy link
Member

Probably better to just add it to sysimg.mk

@IanButterworth
Copy link
Member Author

Any idea why this works locally but not on CI? Seems julia can't find the default sysimage at that point?

@vtjnash
Copy link
Member

vtjnash commented Oct 29, 2022

At some point (on buildbot) we used to run a make build-stats step in CI, which printed this info as well as a variety of other related data-points. Not sure what happened to that step lately

@IanButterworth
Copy link
Member Author

huh.. ok, yeah that already does what this was trying to do.

JuliaCI/julia-buildkite#224

@IanButterworth IanButterworth deleted the ib/sysimage_size branch October 29, 2022 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants