use the correct env variable name to set default openblas num threads #48064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was add to OpenBLAS in OpenMathLib/OpenBLAS#3773 and was supposed to be used in #46844 but was likely typod
KristofferC
added
backport 1.8
|
Yes, this is correct. It was lost in a rebase, apparently. |
staticfloat
approved these changes
Dec 31, 2022
KristofferC
added a commit
that referenced
this pull request
Jan 2, 2023
…#48064) This was add to OpenBLAS in OpenMathLib/OpenBLAS#3773 and was supposed to be used in #46844 but was likely typod (cherry picked from commit 75bc5ee)
41 tasks
KristofferC
added a commit
that referenced
this pull request
Jan 2, 2023
…#48064) This was add to OpenBLAS in OpenMathLib/OpenBLAS#3773 and was supposed to be used in #46844 but was likely typod (cherry picked from commit 75bc5ee)
10 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks to me like this is a typo and causes OpenBLAS to be limited to a single thread if OpenBLAS_jll is in the sysimage (which it is on 1.9 (but not 1.8)).
Fixes JuliaLang/LinearAlgebra.jl#976