Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docstring for @time_imports: explain what is shown (it's not cumulative) #48248

Merged
merged 2 commits into from
Jan 13, 2023
Merged

docstring for @time_imports: explain what is shown (it's not cumulative) #48248

merged 2 commits into from
Jan 13, 2023

Conversation

tfiers
Copy link
Contributor

@tfiers tfiers commented Jan 12, 2023 •
edited
Loading

@tfiers tfiers mentioned this pull request Jan 12, 2023
Closed
@gbaraldi
Copy link
Member

Could we print the total value when using @time_imports so it's clearer even, and I also imagine that people might want that.

@IanButterworth
Copy link
Member

Could we print the total value when using @time_imports so it's clearer even, and I also imagine that people might want that.

It's not straightforward. See #47101

@gbaraldi
Copy link
Member

I see, couldn't we at least add up all the times, and also figure out what that extra time is :).

@tfiers @IanButterworth
Update stdlib/InteractiveUtils/src/macros.jl
35f4a69 
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
@tfiers
Copy link
Contributor Author

tfiers commented Jan 13, 2023

I see, couldn't we at least add up all the times, and also figure out what that extra time is :).

Yes, would be nice.
Something for another PR!

IanButterworth, thanks for the edit. GTM for me

@IanButterworth IanButterworth merged commit eb5f6d6 into JuliaLang:master Jan 13, 2023
@tfiers tfiers deleted the patch-1 branch January 13, 2023 16:03
@IanButterworth IanButterworth added the backport 1.9 Change should be backported to release-1.9 label Jan 13, 2023
KristofferC pushed a commit that referenced this pull request Jan 13, 2023
@tfiers @KristofferC
docstring for @time_imports: explain what is shown (it's not cumula…
ba490ff 
…tive) (#48248)

Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
(cherry picked from commit eb5f6d6)
@KristofferC KristofferC mentioned this pull request Jan 13, 2023
Merged
41 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanButterworth IanButterworth IanButterworth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tfiers @gbaraldi @IanButterworth @KristofferC