REPLCompletions: unswitch Union of same UnionAll results
#50483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit the inference-base REPL completion algorithm converts `Union` result of same `UnionAll` instances to `UnionAll` of `Union`s so that it can use the field information of the `UnionAll`. This allows us to get completions for cases like: ```julia julia> union_somes() = rand() < 0.5 ? Some(1) : Some(2.); julia> union_somes().| # completes to `value` ```
aviatesk
added a commit
that referenced
this pull request
Jul 11, 2023
This generalizes the idea of #50483 and enables field completions when the result type is inferred to be `Union{A,B}` where `A` is not necessarily the same type as `B`.
vtjnash
reviewed
Jul 11, 2023
Comment on lines
+344
to
+346
| Head = (typename::Core.TypeName).wrapper | ||
| unionparams = Any[ Union{Any[(t::DataType).parameters[i] for t in ts]...} for i in 1:n ] | ||
| return Head{unionparams...} |
There was a problem hiding this comment.
This is very much illegal from a type variance perspective. Are you sure we shouldn't be using something like typejoin instead that preserves subtyping correctness on the answer?
There was a problem hiding this comment.
The discussion is ongoing in #50511.
aviatesk
added a commit
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit the inference-based REPL completion algorithm converts
Unionresult of sameUnionAllinstances toUnionAllofUnions so that it can use the field information of theUnionAll.This allows us to get completions for cases like: