REPLCompletions: allow field completions for Union results
#50503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This generalizes the idea of #50483 and enables field completions when the result type is inferred to be `Union{A,B}` where `A` is not necessarily the same type as `B`.
vtjnash
reviewed
Jul 11, 2023
| end | ||
|
|
||
| function add_field_completions!(suggestions::Vector{Completion}, name::String, @nospecialize(t)) | ||
| if isa(t, Union) |
There was a problem hiding this comment.
Suggested change
| if isa(t, Union) | |
| t = Base.unwrap_unionall(t) | |
| if isa(t, Union) |
vtjnash
reviewed
Jul 11, 2023
|
The check performed just above ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes the idea of #50483 and enables field completions when the result type is inferred to be
Union{A,B}whereAis not necessarily the same type asB.