Revert "SROA: generalize unswitchtupleunion optimization"
#50511
+21
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3995278.
|
I thought this was fine, since we never rewrap it, only look at the typename of the resulting DataType. |
|
Yeah, the resulting type |
|
These are also (permanently) very expensive for the runtime to have created. That is not wise to trigger that. If you just need the name, we already have several utilities for that. |
aviatesk
added a commit
that referenced
this pull request
Jul 12, 2023
Since construction of `UnionAll` of `Union`s can be expensive. The SROA pass just needs to look at type name information and do not need to propagate full type objects. - xref: <#50511 (comment)> - closes #50511
|
What do you think about #50522? |
aviatesk
added a commit
that referenced
this pull request
Jul 12, 2023
Since construction of `UnionAll` of `Union`s can be expensive. The SROA pass just needs to look at type name information and do not need to propagate full type objects. - xref: <#50511 (comment)> - closes #50511
aviatesk
added a commit
that referenced
this pull request
Jul 13, 2023
Since construction of `UnionAll` of `Union`s can be expensive. The SROA pass just needs to look at type name information and do not need to propagate full type objects. - xref: <#50511 (comment)> - closes #50511
aviatesk
added a commit
that referenced
this pull request
Jul 13, 2023
#50522) Since construction of `UnionAll` of `Union`s can be expensive. The SROA pass just needs to look at type name information and do not need to propagate full type objects. - xref: <#50511 (comment)> - closes #50511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #50502. Covariant transforms are not sound for types other than Tuple.