-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation to libdl module #52825
Conversation
The current description this PR seems a little bit misleading to me — even without Libdl, you can link Julia code to runtime shared libraries via the |
I think that's a bit of a distinction without a difference; Lines 75 to 78 in b4d857b
|
Good point, but in principle that could change in the future, being an internal implementation detail. My point is that we don't want to imply that ordinary users need to |
Then shall I reference ccall itself in this documentation? |
The Maybe something like this? |
Sure, that sounds good to me. |
Now that #52723 is merged, you'll need to update julia/stdlib/Libdl/test/runtests.jl Lines 333 to 337 in f286d44
@testset "Docstrings" begin
@test isempty(Docs.undocumented_names(Libdl))
end |
Looks like you had a merge problem, and a whole bunch of unrelated commits are now included in this PR. 😢 |
7b121ab
to
3ed49fd
Compare
Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
Co-authored-by: Max Horn <max@quendi.de>
Can one get a preview of the documentation from CI, or do I need to checkout this branch locally to verify it builds the manual correctly with the recent change to use a |
We need this #45744 and then upload the generated HTML |
It looks like doctest is supposed to give you a download link, but fails due to:
|
Part of #52725