Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to specify heap size hint as a percent #52979

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

JeffBezanson
Copy link
Member

also fix overflowed subtraction with size hints < 250mb --- we should pick some minimum soft heap limit; I chose 1mb here but it could be anything.

@JeffBezanson JeffBezanson added the GC Garbage collector label Jan 19, 2024
doc/man/julia.1 Outdated Show resolved Hide resolved
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KristofferC
Copy link
Member

Bump, can be merged?

@vtjnash
Copy link
Member

vtjnash commented Feb 13, 2024

No, it failed on CI:


2024-02-01 04:27:38 UTC	Error in testset cmdlineargs:
2024-02-01 04:27:38 UTC	Test Failed at C:\buildkite-agent\builds\win2k22-amdci6-2\julialang\julia-master\julia-ec4182e384\share\julia\test\cmdlineargs.jl:1059
2024-02-01 04:27:38 UTC	  Expression: abs(maxmem - (hint - 250 * 1024 * 1024)) / maxmem < 0.01
2024-02-01 04:27:38 UTC	   Evaluated: 4.170485178629558 < 0.01

@vtjnash vtjnash added this to the 1.11 milestone Feb 13, 2024
also fix overflowed subtraction with size hints < 250mb
@JeffBezanson
Copy link
Member Author

Seems I did not account for 32-bit machines with 32gb of memory 🤔 😕

@vtjnash
Copy link
Member

vtjnash commented Feb 13, 2024

Nobody ever does, until they realize it is probably the most common 32 bit machines now, haha

@JeffBezanson JeffBezanson merged commit 3e6ff3d into master Feb 14, 2024
7 checks passed
@JeffBezanson JeffBezanson deleted the jb/heappercent branch February 14, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GC Garbage collector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants