Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links to Pkg.jl documentation #53374

Closed
wants to merge 10 commits into from
Closed

Fix broken links to Pkg.jl documentation #53374

wants to merge 10 commits into from

Conversation

burtonjosh
Copy link

@burtonjosh burtonjosh commented Feb 17, 2024 •
edited
Loading

Some dead links in the documentation for v1.10, this points to the most up to date version of the Pkg.jl docs

Fixes #53348

Hopefully I'm requesting to merge to the correct branch, please let me know if I need to change anything!

KristofferC and others added 3 commits February 6, 2024 14:44
@KristofferC
Backports release 1.10 (JuliaLang#53201)
4745ef8 
A few stragglers.

Backported PRs:
- [x] JuliaLang#53091 <!-- Ensure elision of `require_one_based_indexing` with
high-dim array views -->
- [x] JuliaLang#53117 <!-- Try to fix incorrect documentation of `nthreads` -->
- [x] JuliaLang#52855 <!-- Fix variable name in scaling an `AbstractTriangular`
with zero alpha -->
- [x] JuliaLang#52952 <!-- [REPLCompletions] enable completions for `using
Module.Inner|` -->
- [x] JuliaLang#53101 <!-- Inplace transpose for unit Triangular may skip
diagonal -->

Need manual backport:
- [ ] JuliaLang#52505 <!-- fix alignment of emit_unbox_store copy -->

Non-merged PRs with backport label:
- [ ] JuliaLang#53125 <!-- coverage: count coverage where explicitly requested by
inference only -->
- [ ] JuliaLang#52694 <!-- Reinstate similar for AbstractQ for backward
compatibility -->
- [ ] JuliaLang#51479 <!-- prevent code loading from lookin in the versioned
environment when building Julia -->
@KristofferC
release-1.10: set VERSION to 1.10.1 (JuliaLang#53306)
7790d6f
@burtonjosh
fix broken links to Pkg.jl documentation
5b38940
@ViralBShah
Copy link
Member

Can you make this PR to master instead of release-1.10? We'll then mark it for backporting to pull it into 1.10, 1.11, etc. It may be simplest to open a new PR.

@ViralBShah ViralBShah closed this Feb 18, 2024
@burtonjosh
Copy link
Author

sure no problem! The issue I ran into was that the same links in master are not broken, since they were updated in this PR #52384 , so I don't know exactly how to change anything in master so that release-1.10 would get updated? Sorry for the confusion.

@ViralBShah
Copy link
Member

Hmm. @KristofferC Can we merge this PR directly into release-1.10?

@ViralBShah ViralBShah reopened this Feb 18, 2024
@ViralBShah ViralBShah added the docs This change adds or pertains to documentation label Feb 18, 2024
@giordano
Copy link
Contributor

I think release-1.10 is the wrong branch, should have targeted the backport branch, and if this PR is just copying another PR then the other PR should be labelled as backport, which also retains authorship.

@burtonjosh
Copy link
Author

It's not quite a copy of #52384, since in #52102 the page 5. Creating Packages from the Pkg.jl documentation has been copied into the official Julia documentation as a tutorial: https://docs.julialang.org/en/v1.11-dev/tutorials/creating-packages/#adding-tests-to-packages . This means the internal referencing with @ref can't be used in 1.10, which is why I've had to just update the link directly.

should have targeted the backport branch

I looked for this but couldn't find anything relevant, is there a specific branch you're referring to?

@giordano
Copy link
Contributor

I looked for this but couldn't find anything relevant, is there a specific branch you're referring to?

backport-1.1.0

@ViralBShah
Copy link
Member

@giordano Did you mean backport-1.10, because your link is to backport-1.1.0 (which is really old).

IanButterworth and others added 5 commits February 20, 2024 15:20
@IanButterworth @KristofferC
Profile: add notes to print() docs (JuliaLang#53205)
9b6c58d 
(cherry picked from commit 9bafc53)
@KnutAM @KristofferC
Document --heap-size-hint in Command-line Interface (JuliaLang#50480)
3096e31 
Almost a direct copy of the output in `julia --help`.

Closes JuliaLang#50588

Co-authored-by: Max Horn <max@quendi.de>
(cherry picked from commit c5ad467)
@christiangnrd @KristofferC
Fix typo in Sys.total_memory docstring. (JuliaLang#53301)
72fed47 
Fixes JuliaLang#53298.

(cherry picked from commit 81c6526)
@KristofferC
bump NetworkOptions
ff4bc0d
@KristofferC
do not call worker_from_id with pid<1
988f154
@carstenbauer
Copy link
Member

I would assume he meant https://github.com/JuliaLang/julia/tree/backports-release-1.10

@giordano giordano changed the base branch from release-1.10 to backports-release-1.10 February 22, 2024 14:38
@JeffBezanson
fix code coverage bug in tail position and else (JuliaLang#53354)
06fc057 
This was due to lowering keeping the same location info for the inserted
`return` or `goto` statement, even though the last seen location might
not have executed.

Also fixes inliner handling of the sentinel `0` value for code
locations.

(cherry picked from commit 61fc907)
@JeffBezanson JeffBezanson force-pushed the backports-release-1.10 branch from dcaabe8 to 06fc057 Compare February 22, 2024 18:29
@KristofferC KristofferC force-pushed the backports-release-1.10 branch from baa56c5 to 5d971b9 Compare February 26, 2024 13:57
@lgoettgens
Copy link
Contributor

This PR now somehow seems to contain way too many commits. The only "real" changes are in 5b38940 (#53374), the rest seems to be from the https://github.com/JuliaLang/julia/tree/backports-release-1.10 branch.
@KristofferC is this fine to merge like this into the backports branch? If not, @burtonjosh would need to rebase it onto the newest https://github.com/JuliaLang/julia/tree/backports-release-1.10 to get rid of the redundant commits.

@KristofferC KristofferC deleted the branch JuliaLang:backports-release-1.10 February 27, 2024 09:19
@lgoettgens
Copy link
Contributor

This shouldn't have been closed. Can someone reopen it again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@burtonjosh @ViralBShah @giordano @carstenbauer @lgoettgens @KristofferC @IanButterworth @KnutAM @christiangnrd @JeffBezanson