tweak code loading to make Revise happy #53406
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a bit of an inconsistency in an internal code loading function where with an stdlib it gives a path to the entry file while with the normal package we get the path to the folder:
For Base itself this turns out to not matter but Revise uses some internals from code loading:
https://github.com/timholy/Revise.jl/blob/dbbeb3594a4ea3eebd861e8ceea8fc746efc0f82/src/pkgs.jl#L410
and this causes it to get upset.
I believe timholy/Revise.jl#806 will fix it in Revise but might as well add this here as well.