-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docstring for SMALL_ALGORITHM #53807
Conversation
As I mentioned here, we may want to change this alias from InsertionSort to some other algorithm in the future. By adding a docstring that defines SMALL_ALGORITHM as an alias for InsertionSort, you make it a breaking change to later switch to a new default algorithm for small inputs. Anything we write in this docstring must be true now and stay true in all future versions of Julia unless we explicitly mention that it is unstable. It would be better to say what this constant is for (i.e. it's an alg good for sorting small vectors) and, optionally, say what it is currently defined as, noting that that is subject to change. See
|
So I can say it is am default algorithm for short arreys |
yes |
Better now |
Will this PR be marged as one commit to master? |
Yes. |
Co-authored-by: Lilith Orion Hafner <lilithhafner@gmail.com>
Thanks! This should be ready to merge once CI passes |
You are welcome |
Seems like it could add a bit more explanation, per my suggestion above. |
I will fix it ASAP When I get to the computer |
Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
Part of #52725.
@stevengj