Reland " Use copyto! in converting Diagonal/Bidiagonal/Tridiagonal to Matrix #53912 " #54459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
the
re-land
dkarrasch
approved these changes
May 15, 2024
|
Ready to go, isn't it? |
|
Yes, it's ready |
jishnub
added a commit
that referenced
this pull request
May 17, 2024
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Jul 12, 2024
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Jul 12, 2024
…#53909" (JuliaLang#54460) This was reverted in JuliaLang#54332. This needs JuliaLang#54459 for the tests to pass. Opening this now to not forget about it.
KristofferC
pushed a commit
to JuliaLang/LinearAlgebra.jl
that referenced
this pull request
Nov 14, 2024
…#54460) This was reverted in JuliaLang/julia#54332. This needs JuliaLang/julia#54459 for the tests to pass. Opening this now to not forget about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reverted in #54332, but the core idea is unrelated to the
_unsetindex!change. The tests forundefindices are now reverted.