Library doesn't build w/ ICC on OSX

[amanoel]

Following the discussion at JuliaLang/julia#9145, the .s extension must be capitalized (and the Makefile changed accordingly) in order for ICC to be able to build it on OSX.
I'm not sure if doing this wouldn't break the build on other OSes though...

[tkelman]

That would surprise me. We only use this library on OSX anyway.

[amanoel]

Hmm, if it's only used in OSX, wouldn't it be a good idea to always use the system-provided library?
I've tried using the USE_SYSTEM_LIBUNWIND=1 flag and apparently it's also a good way to circumvent this.

[tkelman]

You'd have to ask @Keno exactly what purpose this serves. I dunno the difference USE_SYSTEM_LIBUNWIND would make in practice.

[Keno]

You'd get less accurate profiles. The modifications in this library have some heuristics that allow it to unwind from non-callsite locations.

[nolta]

Another option would be to add -x assembler-with-cpp to SFLAGS.

Tried to fix this, but i don't have permission.

[amanoel]

Can confirm make CC="icc" SFLAGS="$SFLAGS -x assembler-with-cpp" works!