Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added quotes around linked libs for ld, removed extra whitespace. #90

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Added quotes around linked libs for ld, removed extra whitespace. #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ function run_test((test_name, test_expected_outputs, test_success), libblas_name
if needs_m32()
push!(cflags, "-m32")
end

ldflags = String[
# Teach it to find that libblas and its dependencies at build time
("-L$(pathesc(libdir))" for libdir in libdirs)...,
("\"-L$(pathesc(libdir))\"" for libdir in libdirs)...,
Copy link

@vtjnash vtjnash Sep 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
("\"-L$(pathesc(libdir))\"" for libdir in libdirs)...,
("-L$(Base.shell_escape_posixly(libdir))" for libdir in libdirs)...,

?

"-l$(libblas_name)",
]

Expand All @@ -38,7 +38,7 @@ function run_test((test_name, test_expected_outputs, test_success), libblas_name
@error("compilation failed", srcdir, prefix=dir, cflags=join(cflags, " "), ldflags=join(ldflags, " "))
end
@test success(p)

env = Dict(
# We need to tell it how to find CSL at run-time
LIBPATH_env => append_libpath(libdirs),
Expand Down