You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One suggestion would be overload Base.getproperty/Base.propertynames for cases of the second kind (I think these are just LPDistLoss, L1DistLoss, L2DistLoss, but I haven't checked lately), or to implement StatsBase.params or both.
I ran into this issue when wrapping the losses for use in MLJ and was obliged to write my own interface, which is not robust to extensions of LossFunctions.jl
The text was updated successfully, but these errors were encountered:
Yes, instead of fixing things with glue code downstream, it would be much better to have it fixed here. The situation described is not ideal, and we appreciate if you can try to improve the interface here instead of wrapping a new one in MLJ.jl next time 🙏🏽
Perhaps I'm missing something, but this does not appear to exist at present. For most losses with a parameter, you access using property, as in
But for an LPDistLoss there no field for
p
, only a type parameter:One suggestion would be overload
Base.getproperty
/Base.propertynames
for cases of the second kind (I think these are justLPDistLoss
,L1DistLoss
,L2DistLoss
, but I haven't checked lately), or to implementStatsBase.params
or both.I ran into this issue when wrapping the losses for use in MLJ and was obliged to write my own interface, which is not robust to extensions of LossFunctions.jl
The text was updated successfully, but these errors were encountered: