Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a check_retraction function. #599

Closed
kellertuer opened this issue May 5, 2023 · 0 comments · Fixed by JuliaManifolds/ManifoldsBase.jl#187
Closed

Implement a check_retraction function. #599

kellertuer opened this issue May 5, 2023 · 0 comments · Fixed by JuliaManifolds/ManifoldsBase.jl#187
Labels
good first issue Good for newcomers small issue ... hopefully

Comments

@kellertuer
Copy link
Member

Manopt/Matlab has a nice function to numerically check retractions

https://github.com/NicolasBoumal/manopt/blob/master/manopt/tools/checkretraction.m

which requires that the exponential map is implemented. I think it should even be possible to check two retractions – since both are linear approximations of exp, they should also be of linear error when comparing them directly. So if you trust one retraction you could check another one.

And maybe one could even extend this to inverse retractions (or maybe even to vector transports?) The overall scheme to implement (maybe even with a bit of code duplication from there) is very similar to the numerical check for gradients and Hessians over in Manopt.jl, see https://manoptjl.org/stable/helpers/checks/

@kellertuer kellertuer added good first issue Good for newcomers small issue ... hopefully labels May 5, 2023
@kellertuer kellertuer changed the title Check_retraction Implement a check_retraction function. May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers small issue ... hopefully
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant