[RFC] Move arithmetic functions into submodule FixedPointArithmetic
#292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimikage
force-pushed
the
arithmetic_module
branch
from
65c6363 to
c90245a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #292 +/- ##
==========================================
+ Coverage 96.93% 97.02% +0.08%
==========================================
Files 7 10 +3
Lines 784 806 +22
==========================================
+ Hits 760 782 +22
Misses 24 24 ☔ View full report in Codecov by Sentry. |
kimikage
force-pushed
the
arithmetic_module
branch
from
c90245a to
e967034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for improved overflow handling. (closes #239)
We should probably discuss the module structure in OverflowContexts.jl.
xref: JuliaMath/OverflowContexts.jl#7
Even though these functions will be exposed differently in the future by the package extension mechanism, I believe that their implementation should be there statically.
There is a slight tradeoff between an ideal module structure and maintainability.
The proposed file structure follows the conventional file structure.
That is, the
FixedPointcommon implementations are in onearithmetic.jl, and the specializations specific toFixedandNormedare in*_arithmetic.jl.In terms of modularity, it might be better to have separate files for each strategy, such as
Checked.However, as noted above, I do not intend for them to be loaded/compiled independently.
Submodule names such as
Wrappingare also debatable.The current proposal comes from the following reasons:
CheckedArithmeticconflicts with the package nameFixedPointCheckedArithmetic,FixedPointChecked, and so on are redundantFixedPointNumbersBase.CheckedThe automatic formatter has removed the spaces in the type parameters, which I will try to restore later.